Make it possible to compile datafusion-common without default features #7625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Thank you @jonmmease -- this makes sense to me. I took the liberty of pushing a commit to this branch that fixes the cargo.toml formatting to get CI to pass.
Thanks! |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
apache#7625) * Fix parquet optional in datafusion-common * disable default datafusion-common features for dependent crates that don't need parquet * fmt * run tomlformat --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7624
Rationale for this change
Currently
datafusion-commonhas a default feature ofparquet. But some of the parquet functionality was not guarded by#[cfg(feature = "parquet")]conditionals, so it was not possible to compile the crate with theparquetfeature disabled.What changes are included in this PR?
This PR adds conditionals. It also sets
default-features = falsefor all of the datafusion crates that depend ondatafusion-commonbut don't require the parquet functionality.Are these changes tested?
By adding
default-features = falseto the crates that depend ondatafusion-commonbut don't need parquet support, we ensure that it's possible to compiledatafusion-commonwithout the default features.Are there any user-facing changes?
no